Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused JsTibber, JsEvManager, JsSlacSimulator modules #896

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

corneliusclaussen
Copy link
Contributor

Describe your changes

Removing Js modules that are no longer in use or have been replaced by C++ variants

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I have no problem deleting the Js modules. If this bothers someone, they will get in touch.

@SebaLukas
Copy link
Contributor

SebaLukas commented Nov 6, 2024

Right now the C++ YetiSimulator PR is not yet merged. So after merging #862 this PR can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants